Always that run the command `vercel env pull` is adding an extra rule `.env*local` to `.gitignore`!

📝 Description

This is not a critical bug but is little boring have to remove this extra rule always that I added a new rule to vercel.

🔎 Details

CLI Version: 37.12.1
OS: Microsoft Windows 11 Pro

📷 Evidence

evidence

🐾 Steps to reproduce the issue

Using an OS that has end-of-line crlf by default like Windows
Run vercel env pull Into a project that already has a the vercel rules into the .gitignore

🧪 What's the expected result?

Only add the rule .env*.local when the .gitignore does not have it.

❌ What's the actual result?

Is adding the same rule multiple times.

🫚 Root cause

This is happeing because this condition in this file packages/cli/src/util/link/add-to-gitignore.ts this is the code:

1const EOL = gitIgnore.includes('\r2') ? '\r3' : os.EOL;4// ..5if (!gitIgnore.split(EOL).includes(ignore)) { /* add the rule */

In some cases this condition can be translated to:

1const EOL = gitIgnore.includes('\r2') ? '\r3' : '\r4';

For example in my case my file is using lf = but my os use crlf = \r by default that is this condition will never be true.

✅ Solution

I did a few changes in this code that I would like to check first here to avoid a forgotten PR!

Changes

Move this file add-to-gitignore.ts from src/util/link to src/util since it is not only used in link command but also in env command.
Change the code to check as an string. It is good for two reasons:
- The .gitignore can have multiples rules at the same line
- Doesn't matter what is the end-of-line

1if (gitIgnore.includes(ignore)) return isGitIgnoreUpdated;

The last change that I would like to check if it is ok 🤔 or is too much. I created a function to get the dominant end-of-line and use it when add a new line. This is the code:

1function getDominantEOL(text: string) {2  const lines = (text.match(/\r3|4/g) ?? []) as Array<'\r5' | '6'>;78  const {9    '10': LFCount,11    '\r12': CRLFCount,13  } = lines.reduce(14    (counter, lineEnding) => {15      counter[lineEnding] += 1;16      return counter;17    },18    { '19': 0, '\r20': 0 },21  );2223  const dominantEOL = LFCount > CRLFCount ? '24' : '\r25';2627  return LFCount === CRLFCount ? os.EOL : dominantEOL;28}

It can be simpler checking if there is any kind of end-of-line otherwise it uses the os end-of-line:

1function getEOL(text: string) {2  if (text.includes('\r3')) return '\r4';5  if (text.includes('6')) return '7';8  return os.EOL;9}

I will open the PR soon and leave the link to it here! If you have any suggestions I will be happy to apply it 😊