Hi, i often get this message, although everything appears as successful. Any idea what do please?
My branch protection rules are as follows:
Hi, @zbycz!
A few things to try:
Thanks, it happens only from time to time in one specific project. When I push another commit, it usually works.
Lets close it now, i will write if it happens again ![]()
Hi, this has happened to me again several times. Usually with a user pushing to a fork. I think it may be relevant by having an old “master” branch.
This particular PR is also having old base branch - but Github is showing Merging is blocked Missing successful active Preview deployment. and nothing about the branch. Could it be some Github bug?
https://github.com/zbycz/osmapp/pull/1110
I will leave to PR open for some time for possible investigation.
//edit somebody else is having the same issue
I am having the same issue again - possibly caused by old master branch. Pushing another commit usually fixes that, but it is very annoying.
@pawlean
.. should i wait with the merging of that PR? Or it is not needed for debugging?
@anshumanb - could you perhaps look into that?
thanks
I left the PR still unmerged.
Hi @pavelzetradex, let me check what could be the issue.
Thanks for looking into it.
This happens only very seldom - the PR general: Add Mapillary API key to .env by amenk · Pull Request #1110 · zbycz/osmapp · GitHub is the last one. If it happens and somebody pushes another commit, it is fixed.
I suspect, that it only happens when a non-contributor create a PR from their fork, and than the master branch gots some new commits. It happpens only on this repo (i dont have vercel anywhere else).
Thanks for sharing additional information @pavelzetradex. The PR you shared seems to be working now, as you said.
Let me share your analysis with our team to see if this is a know issue or edge case.
Thanks @anshumanb - though not sure what you mean. The PR i shared above is broken exactly in the way described above. Maybe you meant the link is working? ![]()
Oh, thanks for confirming. I got confused because I don’t see the merge button, only that the checks passed.
Hi @zbycz, thanks for sharing this.
I reached out to the team and I’ve got a question for you: Can you confirm if you’re using this rule in your repo settings/rules ?
Can you also share the expanded “additional settings”?
Thanks @anshumanb ![]()
My branches/master/rules settings:
Deployment to preview required:
And branch not required to be up-to-date:
I’m having the same issue, any updates on a fix?
No, my repo is not a monorepo. Btw, the message on the PR changed - now it says there are merge conflicts. So i am going to resolve the PR.. it doesnt show anything useful now. Anyway, thanks for your help. ![]()